Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xpath injection #10162 #10163

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Xpath injection #10162 #10163

merged 4 commits into from
Aug 31, 2023

Conversation

cgocast
Copy link
Contributor

@cgocast cgocast commented Aug 30, 2023

No description provided.

@cgocast
Copy link
Contributor Author

cgocast commented Aug 31, 2023

IMHO, the results of the backward compatibility tests are not very relevant for the change I made. The tests spot a breaking change for psalm internal class TaintKind, which is not meant to be directly used by psalm plugins.

If someone disagrees with me, I'll be glad to make the necessary changes if he gives me a hint on how to do it.

@weirdan
Copy link
Collaborator

weirdan commented Aug 31, 2023

The tests spot a breaking change for psalm internal class TaintKind,

It's not internal though.

I'll be glad to make the necessary changes if he gives me a hint on how to do it.

Target master (future Psalm 6). It's ok to have BC breaks in that branch.

@cgocast cgocast changed the base branch from 5.x to master August 31, 2023 12:12
@cgocast
Copy link
Contributor Author

cgocast commented Aug 31, 2023

Target master (future Psalm 6). It's ok to have BC breaks in that branch.

Thank you @weirdan for your advice. I changed the target branch accordingly.

@weirdan weirdan added the release:feature The PR will be included in 'Features' section of the release notes label Aug 31, 2023
@weirdan weirdan merged commit 77650e7 into vimeo:master Aug 31, 2023
38 of 40 checks passed
@weirdan
Copy link
Collaborator

weirdan commented Aug 31, 2023

Thanks!

@cgocast cgocast mentioned this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants